Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #1

Merged
merged 5 commits into from
Jul 10, 2019
Merged

Fix bugs #1

merged 5 commits into from
Jul 10, 2019

Commits on May 6, 2019

  1. Fix typo

    modos189 authored and johndoe committed May 6, 2019
    Configuration menu
    Copy the full SHA
    258ad34 View commit details
    Browse the repository at this point in the history
  2. fix broken removeMarker

    johndoe committed May 6, 2019
    Configuration menu
    Copy the full SHA
    5b67c61 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2019

  1. fix exception in mouse event handler with empty CanvasMarkerLayer

    `this._markers` is undefined in `_searchPoints`, called from event listeners.
    Now we check markers existence in the beginning of handlers.
    
    Note 1:
    Could be fixed in some another place:
     e.g. check `_markers` in `_searchPoints`
     ...or initialize (empty) `_markers` on CanvasMarkerLayer init
    
    Note 2:
    `!this._map` removed from condition in `_onMouseMove:` 'cause
    it's never should be true as we detach listeners on remove from map
    johndoe committed May 7, 2019
    Configuration menu
    Copy the full SHA
    6a81b9c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2019

  1. Configuration menu
    Copy the full SHA
    ab64e18 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2019

  1. fix exception if image is not loaded (yet) / bad url / etc

    Was protected in marker add time, but not on zoom/pan
    
    Sample:
    ```
    VM2992:16252 Uncaught DOMException: Failed to execute 'drawImage' on 'CanvasRenderingContext2D': The HTMLImageElement provided is in the 'broken' state.
        at NewClass._drawImage (<anonymous>:16252:23)
        at NewClass._drawMarker (<anonymous>:16239:22)
        at <anonymous>:16200:22
        at Array.forEach (<anonymous>)
        at NewClass._draw (<anonymous>:16179:16)
        at NewClass._redraw (<anonymous>:16077:18)
        at NewClass.fire (<anonymous>:1867:11)
        at NewClass._move (<anonymous>:5506:9)
        at NewClass._onZoomTransitionEnd (<anonymous>:5963:8)
    ```
    johndoe committed May 12, 2019
    Configuration menu
    Copy the full SHA
    4ade879 View commit details
    Browse the repository at this point in the history