don't mutate configuration when updating http agent #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See TR-1654 - https://jira.int.messagesystems.com/browse/TR-1654 |
ischer
approved these changes
Sep 24, 2019
ischer
reviewed
Sep 24, 2019
| expect(awsMock).to.have.been.calledWith({ | ||
| httpOptions: { agent: sinon.match.any } | ||
| }); | ||
| expect(config).to.deep.equal({ bypassProxy: 'a value' }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accounts team had an SNS outage due to
utils.setHttpAgentmutating the config that is passed in to it. The SQS wrapper passes a config that other services use to this function, and sincebypassProxy = trueby default in the SQS wrapper, the proxy agent is reset for all other services that use that config.