Missing channel handling in full llhd simplification #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sampling the 1911.12606 ATLAS analysis goes without an error now. Conversion is very slow, but this might due to a large number of channels (50) and complexity of the statistical model. |
Does setting signal yields to zero from the start improve speed? |
|
No, it does not. Moreover, some channels report very large uncertainty (I checked only with small number of samples). It seems this is because of the statistical model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes care of cases where information is missing from the patch set. In such a scenario, the signal yields for a given channel are set to zero.
Note: There are several warnings since each comes from a different source and calculation. This may affect the result! The signal patch should always include all the information about each channel.
Thanks to @Rav2 and @Altakach313 for pointing this out.
To install this particular branch use: