Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cambridge neurotech adaptor to wiring > RHD2164 #304

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zm711
Copy link
Contributor

@zm711 zm711 commented Oct 9, 2024

@chrishalcrow, could you check my typing for our PR to make sure I put it in correctly.

To-do

  • share our fixed excel/googlesheet
  • share the intan RH2164 pin map
  • share the adaptor map
  • illustration of the orientation

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (5e96807) to head (9179cf2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files          10       10           
  Lines        1885     1885           
=======================================
  Hits         1685     1685           
  Misses        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zm711
Copy link
Contributor Author

zm711 commented Oct 10, 2024

Also just had my lab also independently verify the wiring too :) docs still to come.

@chrishalcrow
Copy link

Looks good - where are we gonna share the csvs? In the docs somewhere? I could make some gifs of labelled floating cuboids to illustrate the orientations??

@zm711
Copy link
Contributor Author

zm711 commented Oct 11, 2024

I think we can just toss the pictures and excel (or googlesheet link) here in the PR. If you want to give it a go with the gifs do it. I'm trash at that stuff.

@zm711 zm711 changed the title Add cambridge neurotech adaptor to wiring Add cambridge neurotech adaptor to wiring > RHD2164 Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants