Support for fs2 2.3.0 and scala 2.13 #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchlupacek
reviewed
May 3, 2020
| )( | ||
| socketGroup: SocketGroup | ||
| , tlsContext: TLSContext | ||
| ):F[HttpClient[F]] = Sync[F].delay { |
There was a problem hiding this comment.
No need for Sync, I think Applicative will do
| @@ -114,12 +113,10 @@ trait HttpClient[F[_]] { | |||
| def apply[F[_] : ConcurrentEffect : ContextShift : Timer]( | |||
| requestCodec : Codec[HttpRequestHeader] | |||
There was a problem hiding this comment.
Yes, it is required for the websocket client, as we need to do pings there.
| @@ -36,7 +36,7 @@ object HttpServer { | |||
| * Request is not suplied if failure happened before request was constructed. | |||
| * | |||
| */ | |||
| def apply[F[_] : ConcurrentEffect : Timer]( | |||
| def apply[F[_] : ConcurrentEffect : Timer: ContextShift]( | |||
There was a problem hiding this comment.
Could we (and same for client) get rid of apply[F] as being constructor? Lets do mk, and have apply as summoner of the instance
There was a problem hiding this comment.
Changed them both to mk, however server cannot have summoner instance as the result is Stream[F, Unit].
… allow for apply summoing of HttpClient.
|
Hi! Any chance this is going to be merged anytime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marko-asplund and @jhnsmth I have taken pieces of your work and updated the fs2-http to the newest fs2, while dropping the dependency on fs2-crypto as we now have implmentaion in fs2.
I have based it from spinoco compatiblity branch, as we had some fixes I wanted to keep, as such I did not not use your commits if you dont mind.
I am also dropping BASE64 implementation we had here, as fs2 has its own now.