Enable Github actions tests #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hornc
commented
Mar 12, 2021
| self.targets.eval() | ||
| self._set_target(self.targets, indicator) | ||
| else: | ||
| for target in self.targets: | ||
| if type(target) != type(int): | ||
| if not isinstance(target, int): |
There was a problem hiding this comment.
Not 100% sure about this one. The original type(int) is <class 'type'> , I'm assuming this is a mistake and the condition is supposed to be if target is not a Python int (as opposed to a qast_primitives.Int / qast.Int)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been poking at various things here, trying to get a feel for how it all hangs together.
See the test actions as they have run on my fork here: https://github.com/hornc/QEDA/actions
I still have a way to go to understand how the multi-qubit gates are supposed to be laid out, but the unitary gates make sense, and I have created my own simple QASM files, which display nicely as pcbs in KiCad, which is how I noticed the Hadamard gates were Y Gates.
This PR adds Github actions on all pushes. If I keep going, I'd switch to pytest. I didn't want to change too much at first. Let's see how the existing tests run before I go changing everything.