Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #109

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from
Draft

Release #109

wants to merge 49 commits into from

Conversation

ogmedia
Copy link
Contributor

@ogmedia ogmedia commented Aug 12, 2024

This release addresses some inefficiencies and some general fixes around some edge cases:

  • Duplicate check for spending limit members on controlled multisig.
  • Duplicate check for member list on add/change.
  • ProposalCancelV2 - realloc to prevent blocked EOL tx from being reclaimed/closed.
    • Cancel Votes are screened/updated based off current members
  • Tx Close/Reclaim for txs that are stale or have non-existent proposal accounts.
  • Remove member check from Spending limits. Spending limit vec is now sorted to help the invariant check.
  • Execution optimizations (pass signer seeds slice instead of vec, ephemeral signers removed from loop).
  • Utilizing .take() on execution instructions to reduce resource consumption.
  • Added TransactionBuffers so that larger atomic transactions can be assembled.
  • Added custom allocator for more efficient heap management.

vovacodes and others added 6 commits August 9, 2024 00:07
Additional check for duplication upon member config action.
In the case of a controlled multisig (with config_authority), we run a duplicate check on the member keys in the spending limit.
* updated account context for vault closing to incorporate missing proposal account (non init)

* feat(config_transaction_accounts_close,vault_transaction_accounts_close): allow closing stale tx accounts with no proposal

* feat(batch_accounts_close): allow closing stale tx accounts with no proposal

---------

Co-authored-by: Vladimir Guguiev <[email protected]>
* Cancelation realloc and current member state check/retain

* added comment about realloc

* move new vote logic to a v2 ix to preserve backwards compatibility

* new proposal cancel instruction (v2)

* new account context labeled as ProposalCancel specifically

* add the retain old member keys to existing cancel logic
…p-members-check

feat(spending_limits): allow spending limits for non-members
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-sdk-typedoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:31pm

Copy link
Contributor

@bguillaumat bguillaumat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link

@Palmaswell Palmaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 👌

Copy link

@0xRigel 0xRigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

programs/squads_multisig_program/src/lib.rs Outdated Show resolved Hide resolved
* fix(vault_seeds): removed iterations

* pass vault seed slice directly

* fix(execute-tx-message): optimization - moved signer seed iterations out of loop
Fixed "threshold" typo
* heap optimization/removing inefficient clone

* add: comments around explicit usage and consequences of `core::mem::take`

---------

Co-authored-by: slg <[email protected]>
* wip: incremental tx uploading

* add: incremental tx uploading ixns

* generate sdk & add tests

- createbuffer & extend passing*
- createVaultTxFromBuffer failing with "Program Failed to Complete"

* base case tests passing

* add comments for clarity

* expose buffer close & add test

* add: extra tests -- buffer creation and extension

* add: tests for transactionBufferClose

* fix: uncomment tests

* fix: space allocation buffer creation

* add: additional helper for buffer size

* add: buffer deserialization checks

* dummy vercel commit

* feat: tx buffer example & out of memory example

---------

Co-authored-by: Joey Meere <[email protected]>
* wip: incremental tx uploading

* add: incremental tx uploading ixns

* generate sdk & add tests

- createbuffer & extend passing*
- createVaultTxFromBuffer failing with "Program Failed to Complete"

* base case tests passing

* add comments for clarity

* expose buffer close & add test

* add: extra tests -- buffer creation and extension

* add: tests for transactionBufferClose

* fix: uncomment tests

* fix: space allocation buffer creation

* add: additional helper for buffer size

* add: buffer deserialization checks

* dummy vercel commit

* feat: tx buffer example & out of memory example

* initial commit

* feat: flipped bump allocator on its head

* feat: heap tests, buffer chunking util + refactor

* remove: heap test ix & add: allocator docs

* rm: heapTest testing suite

* add: script for running anchor test in detach

* revert: Cargo.toml anchor-lang change

* linting: cargo fmt

---------

Co-authored-by: Joey Meere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants