Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous code signing #1278

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Synchronous code signing #1278

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7257b46
Making code signing sychronous so it doesn't freeze docker
Mar 22, 2018
032d07b
Removing extra log line
Mar 22, 2018
689d736
Undo edits to .gitignore
Mar 22, 2018
e4fb452
Update .gitignore file
jonoomph Mar 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Update/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,16 +404,16 @@ public void Releasify(string package, string targetDir = null, string packagesDi

new DirectoryInfo(pkgPath).GetAllFilesRecursively()
.Where(x => Utility.FileIsLikelyPEImage(x.Name))
.ForEachAsync(async x => {
if (isPEFileSigned(x.FullName)) {
.ForEach(x => {
if (isPEFileSigned(x.FullName))
{
this.Log().Info("{0} is already signed, skipping", x.FullName);
return;
}

this.Log().Info("About to sign {0}", x.FullName);
await signPEFile(x.FullName, signingOpts);
}, 1)
.Wait();
signPEFile(x.FullName, signingOpts).Wait();
});
});

processed.Add(rp.ReleasePackageFile);
Expand Down