Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added updateOnly option to createShortcut command #1368

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SamvelRaja
Copy link

The createShorcutForExecutable method has the ability to do differentiation between whether it is a updateOnly action or a create Action but this ability is not exposed via command line.

This PR enables the feature, feel free to decline it if it is not aligning with the roadmap.

src/Update/Program.cs Outdated Show resolved Hide resolved
@SamvelRaja
Copy link
Author

@kutu Changes looks fine?

@kutu
Copy link

kutu commented Feb 11, 2019

@SamvelRaja yes, i have tested it, and it works as expected, thx

@SamvelRaja
Copy link
Author

@kutu will it be merged?
A lot of electron apps would be in need of this feature.

@kutu
Copy link

kutu commented Feb 17, 2019

How do I know, I'm nobody in this project
But I use this in my project now, thanks for PR

@shiftkey shiftkey added the unmergeable Pull requests that do not merge currently into the default branch label Apr 24, 2019
Copy link

@vidia vidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change. I hope that this can get merged in because I have need for a similar feature in a project I'm working on. It looks valid to me, but I am still new to this code so I'll defer to the maintainers.

Looking over the contributing docs, it looks like this needs to be moved to "develop" instead of master, and get merged up. I'm happy to re-create this PR myself if needed to keep this alive.

Adding @shiftkey who marked this as unmergable. What can I do to pick up this work and get it moving?

Editing to add that I have created #1674 to recreate this. @SamvelRaja thanks for creating this in the first place and I hope you don't mind it getting bumped forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unmergeable Pull requests that do not merge currently into the default branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants