Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to package.Id if title not available #1447

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

james1465
Copy link

If a package title is not set in the nuspec tile, normal user installs work fine, but the installation folder set in the Wix for the machine wide installer becomes "%programfiles%\ Installer\ .... " - note the space where the title should be.

When the folder is created this space is silently removed by the operating system, however in the registry Run entry, the space is present. As the name in the registry and the actual path don't match, the machine wide installer never runs.

This change means that the installer falls back to using the id if the name is not available

If a package title is not set in the nuspec tile, normal user installs work fine, but the installation folder set in the Wix for the machine wide installer becomes "%programfiles%\ Installer\ .... " - note the space where the title should be. 

When the folder is created this space is silently removed by the operating system, however in the registry Run entry, the space is present. As the name in the registry and the actual path don't match, the machine wide installer never runs. 

This change means that the installer falls back to using the id if the name is not available
@anaisbetts
Copy link
Contributor

I would rather that Releasify simply fails if title isn't present, can you do this instead?

@james1465
Copy link
Author

Yes I can do that if you're sure, the MS documentation on .nuspec files does this about the title though:

title
A human-friendly title of the package, typically used in UI displays as on nuget.org and the Package Manager in Visual Studio. If not specified, the package ID is used.
Microsoft

So it does feel like going against the spirit of the nuspec format a little not to fallback to the ID.

It's your project through - let me know your thoughts and I'll implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants