-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding flye version 2.9.5 #1058
Conversation
Bioconda image is less than 100 MB while ours is ~250MB. I think it may be good to try a staged build or mamba for this. |
If we want to reduce the size, I think a staged build will be best since the compilation stuff I can work on this at some point in the near future if you're OK with me pushing commits here |
I'm okay with having commits pushed here. I'm unsure when I'll have time to work on this. |
TA DA! I have added a builder stage, and everything appears to run as normal. Now the image is MUCH smaller. When built to app: 191 MB, flye's image on biocontainers is 238 MB.
|
Also, I realized this image was missing a CMD line, so I added it. |
Looks great! Thank you for putting all these together and making the image much smaller. |
76.68 MB on dockerhub. Great improvement! 👏 |
There's a new version of flye!
I think this may be a minor update? According the to the release notes python2 support was dropped.
I think this means a few functions have been rewritten, so this may behave differently than 2.9.4.
I just copied the file from 2.9.4 and updated the software version arg.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)