Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding flye version 2.9.5 #1058

Merged
merged 3 commits into from
Oct 29, 2024
Merged

adding flye version 2.9.5 #1058

merged 3 commits into from
Oct 29, 2024

Conversation

erinyoung
Copy link
Contributor

There's a new version of flye!

I think this may be a minor update? According the to the release notes python2 support was dropped.

I think this means a few functions have been rewritten, so this may behave differently than 2.9.4.

I just copied the file from 2.9.4 and updated the software version arg.

 $ diff flye/2.9.4/Dockerfile flye/2.9.5/Dockerfile 
2c2
< ARG FLYE_VER="2.9.4"
---
> ARG FLYE_VER="2.9.5"

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara
Copy link
Collaborator

Bioconda image is less than 100 MB while ours is ~250MB. I think it may be good to try a staged build or mamba for this.

@kapsakcj
Copy link
Collaborator

If we want to reduce the size, I think a staged build will be best since the compilation stuff gcc g++ make etc. things likely won't be needed at runtime

I can work on this at some point in the near future if you're OK with me pushing commits here

@erinyoung
Copy link
Contributor Author

I'm okay with having commits pushed here. I'm unsure when I'll have time to work on this.

@jessicarowell jessicarowell self-assigned this Oct 10, 2024
@erinyoung
Copy link
Contributor Author

TA DA!

I have added a builder stage, and everything appears to run as normal. Now the image is MUCH smaller.

When built to app: 191 MB, flye's image on biocontainers is 238 MB.

$ docker image ls
REPOSITORY                   TAG                     IMAGE ID       CREATED          SIZE
flye                         app                     67b2b2e89238   4 minutes ago    191MB
quay.io/biocontainers/flye   2.9.5--py39hdf45acc_1   998863804506   8 weeks ago      238MB

@erinyoung
Copy link
Contributor Author

Also, I realized this image was missing a CMD line, so I added it.

@Kincekara
Copy link
Collaborator

Looks great! Thank you for putting all these together and making the image much smaller.

@Kincekara Kincekara merged commit ab858d1 into master Oct 29, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

@Kincekara
Copy link
Collaborator

76.68 MB on dockerhub. Great improvement! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants