Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit config for black and isort #124

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

carlthome
Copy link
Contributor

Just a suggestion but it would be nice to have auto-formatting with black running on this repo, to not have to think manually about code style.

@akx
Copy link
Contributor

akx commented Aug 22, 2024

It would probably be even better to use ruff and ruff-format instead of black and isort :)

@carlthome
Copy link
Contributor Author

I like ruff but my hesitation is that it's from a VC backed tech startup (https://github.com/astral-sh) rather than a FOSS community (https://github.com/psf), so it will probably start pushing premium features and ads eventually (like things usually go when VC is involved).

With that said, ruff is fast and convenient, so maybe why not? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants