Skip to content

Commit

Permalink
only use cr prod for app image too
Browse files Browse the repository at this point in the history
  • Loading branch information
stephen-vakil committed Jul 16, 2024
1 parent e6f0307 commit 495676f
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 13 deletions.
10 changes: 0 additions & 10 deletions .github/actions/build_docker/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ inputs:
image_name:
description: The Docker image name, with the registry prefix
required: true
registry_dev:
description: Docker registry dev
required: true
registry_prod:
description: Docker registry prod
required: true
Expand Down Expand Up @@ -49,13 +46,6 @@ runs:
${{ github.ref_name == 'main' && '' || format('pr-{0}', github.event.pull_request.number) }}
flavor: latest=false

- name: Login to Docker Registry - dev
uses: docker/login-action@v3
with:
registry: ${{ inputs.registry_dev }}
username: ${{ inputs.registry_username }}
password: ${{ inputs.registry_password }}

- name: Login to Docker Registry - prod
uses: docker/login-action@v3
with:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/build_app_docker_image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:

env:
BUILDKIT_PROGRESS: plain
SERVICE_IMAGE_NAME: ${{ github.ref_name == 'main' && vars.CLOUDSMITH_DOCKER_REGISTRY_PROD || vars.CLOUDSMITH_DOCKER_REGISTRY_DEV }}/stackeng/opserver/opserver
SERVICE_IMAGE_NAME: ${{ vars.CLOUDSMITH_DOCKER_REGISTRY_PROD }}/stackeng/opserver/opserver

jobs:
build_docker:
Expand All @@ -36,7 +36,6 @@ jobs:
version: ${{ inputs.version }}
dockerfile_path: ./Dockerfile
image_name: ${{ env.SERVICE_IMAGE_NAME }}
registry_dev: ${{ vars.CLOUDSMITH_DOCKER_REGISTRY_DEV }}
registry_prod: ${{ vars.CLOUDSMITH_DOCKER_REGISTRY_PROD }}
registry_username: ${{ secrets.registry_username }}
registry_password: ${{ secrets.registry_password }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/build_cnab.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
version: ${{ inputs.version }}
dockerfile_path: ./cnab/build/Dockerfile
image_name: ${{ env.CNAB_IMAGE_NAME }}
registry_dev: ${{ vars.CLOUDSMITH_DOCKER_REGISTRY_DEV }}
registry_prod: ${{ vars.CLOUDSMITH_DOCKER_REGISTRY_PROD }}
registry_username: ${{ secrets.registry_username }}
registry_password: ${{ secrets.registry_password }}
Expand Down

0 comments on commit 495676f

Please sign in to comment.