forked from opserver/Opserver
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASCN-250 / ASCN-307: Sandbox move + Discovery GCP deployment targets during CNAB build instead of hard-coding #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-vakil
added
the
deploy-to-sandbox
automatically deploy this pr to sandbox
label
Sep 20, 2024
stephen-vakil
changed the title
ASCN-250: Discovery GCP deployment targets during CNAB build instead of hard-coding
ASCN-250 / ASCN-307: Sandbox move + Discovery GCP deployment targets during CNAB build instead of hard-coding
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some small questions/comments but overall I think this looks good!
WouterDeKort
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we go through another refactor of infrastructure, knowing clusters and other details might change in the future, and knowing we eventually need to install in multiple clusters, we need to be able to discover when running our CNAB deploy which deployment targets (clusters) and deployment groups (projects) we will deploy to, instead of hard-coding them as variables.
Additionally, having to copy/paste all this stuff that doesn't change everywhere is a bit of toil that can be solved by centralize as much as possible into the base image.
This PR therefore does the following:
run.ps1
See this PR for more details on how the base image scripts are organized:
https://github.com/StackEng/base-docker-images/pull/59
How to test
Invoke-CNAB
script until the octopus changes are in place too.