Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCN-250 / ASCN-307: Sandbox move + Discovery GCP deployment targets during CNAB build instead of hard-coding #10

Merged
merged 12 commits into from
Sep 26, 2024

Conversation

stephen-vakil
Copy link

@stephen-vakil stephen-vakil commented Sep 20, 2024

As we go through another refactor of infrastructure, knowing clusters and other details might change in the future, and knowing we eventually need to install in multiple clusters, we need to be able to discover when running our CNAB deploy which deployment targets (clusters) and deployment groups (projects) we will deploy to, instead of hard-coding them as variables.

Additionally, having to copy/paste all this stuff that doesn't change everywhere is a bit of toil that can be solved by centralize as much as possible into the base image.

This PR therefore does the following:

  • Use an updated cnab base image that includes most of our script/logic for deployment
  • Anything app-specific is now in run.ps1

See this PR for more details on how the base image scripts are organized:
https://github.com/StackEng/base-docker-images/pull/59

How to test

  • test locally by running the Invoke-CNAB script until the octopus changes are in place too.
  • test in octopus using this pr branch

@stephen-vakil stephen-vakil added the deploy-to-sandbox automatically deploy this pr to sandbox label Sep 20, 2024
@stephen-vakil stephen-vakil marked this pull request as ready for review September 24, 2024 19:46
@stephen-vakil stephen-vakil changed the title ASCN-250: Discovery GCP deployment targets during CNAB build instead of hard-coding ASCN-250 / ASCN-307: Sandbox move + Discovery GCP deployment targets during CNAB build instead of hard-coding Sep 24, 2024
cnab/app/run.ps1 Outdated Show resolved Hide resolved
Copy link

@WouterDeKort WouterDeKort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some small questions/comments but overall I think this looks good!

@stephen-vakil stephen-vakil marked this pull request as draft September 25, 2024 14:43
@stephen-vakil stephen-vakil marked this pull request as ready for review September 25, 2024 19:14
@stephen-vakil stephen-vakil merged commit 7c54adc into main Sep 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-to-sandbox automatically deploy this pr to sandbox
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants