Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCN-234: Add support for oidc/okta configuration #5

Merged
merged 28 commits into from
Jul 22, 2024
Merged

Conversation

stephen-vakil
Copy link

@stephen-vakil stephen-vakil commented Jul 18, 2024

This adds support for okta authentication to opserver's charts. This required adding environment variables for the various OIDC/okta settings. In getting this working, I found two issues:

  1. When running in a container, the app is hosted over http with https provided via ingress. However, the app, when redirecting to okta, was previously using the same scheme as the Request. As a result, when it was creating the redirectUri for okta, it used http which is not appropriate. I added a shared method and a new setting to handle this -- if the setting is set, it will use https always.
  2. The default connection string's database name set up in the chart was Local.Exceptions which is not appropriate outside of local. I am not sure where the default connection string is used, but in the documentation sample they used master as the database for the default connection string, which seems as good as any?

@stephen-vakil stephen-vakil marked this pull request as ready for review July 19, 2024 18:15
cnab/app/run.ps1 Outdated Show resolved Hide resolved
Copy link

@WouterDeKort WouterDeKort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Adding the HTTPS redirect setting/method makes sense to. Left some small comments but nothing major.

Copy link

@WouterDeKort WouterDeKort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephen-vakil stephen-vakil merged commit e7dcab2 into main Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants