Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table): improve sortable table accessibility #1280

Merged
merged 27 commits into from
May 9, 2023
Merged

fix(table): improve sortable table accessibility #1280

merged 27 commits into from
May 9, 2023

Commits on Oct 13, 2022

  1. Improve a11y support for table sorting

    @allejo
    allejo committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    d4599d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Remove extra classes; add column highlighting

    @allejo
    allejo committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    c6830af View commit details
    Browse the repository at this point in the history

  2. Add quick comment

    @allejo
    allejo committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    57a4515 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Fix missing ending tag

    @allejo
    allejo committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    5d3adef View commit details
    Browse the repository at this point in the history

  2. aria-sort shouldn't always be set on every header

    @allejo
    allejo committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    f99bc57 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Remove column highlighting on sort

    @allejo
    allejo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    946a968 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Merge branch 'develop' into pr/1144

    @dancormier
    dancormier committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    2f0c3c3 View commit details
    Browse the repository at this point in the history

  2. Port table.less changes to refactored styles

    @dancormier
    dancormier committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    4e37924 View commit details
    Browse the repository at this point in the history

  3. test(table): add test for sortable table

    @dancormier
    dancormier committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    87271fc View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Have eslint apply to tests as well

    @allejo
    allejo committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    f984cc0 View commit details
    Browse the repository at this point in the history

  2. It's okay to have unused vars for array destructures

    @allejo
    allejo committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    5cc54b3 View commit details
    Browse the repository at this point in the history

  3. Prettify table code + start more unit tests

    @allejo
    allejo committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    5a24eed View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Merge branch 'develop' into pr/1144

    @allejo
    allejo committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    3ac0cc4 View commit details
    Browse the repository at this point in the history

  2. Changes for latest develop changes

    @allejo
    allejo committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    186b2b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Merge branch 'develop' into pr/1144

    @allejo
    allejo committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    61078bf View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Unit tests for column indicators + aria-sort values

    @allejo
    allejo committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    255c7d9 View commit details
    Browse the repository at this point in the history

  2. Apparently DOM tests are async?

    @allejo
    allejo committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    0232d70 View commit details
    Browse the repository at this point in the history

  3. Make unit tests + eslint happy by void'ing a promise

    @allejo
    allejo committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    9476003 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Merge branch 'develop' into pr/1144

    @giamir
    giamir committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    74d2809 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. update th button styling

    @dancormier
    dancormier committed May 2, 2023
    Configuration menu
    Copy the full SHA
    10b76fb View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. small tweak

    @dancormier
    dancormier committed May 3, 2023
    Configuration menu
    Copy the full SHA
    c7c8fca View commit details
    Browse the repository at this point in the history

  2. minor styling tweak

    @dancormier
    dancormier committed May 3, 2023
    Configuration menu
    Copy the full SHA
    f26ca06 View commit details
    Browse the repository at this point in the history

  3. Update test to check current and legacy markup

    @dancormier
    dancormier committed May 3, 2023
    Configuration menu
    Copy the full SHA
    ea5b100 View commit details
    Browse the repository at this point in the history

  4. lint

    @dancormier
    dancormier committed May 3, 2023
    Configuration menu
    Copy the full SHA
    f30fb6d View commit details
    Browse the repository at this point in the history

  5. Update test description to reflect legacy markup

    @dancormier
    dancormier committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4745d16 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. add comments 

    addresses #1280 (comment)
    @dancormier
    dancormier committed May 9, 2023
    Configuration menu
    Copy the full SHA
    a141f18 View commit details
    Browse the repository at this point in the history

  2. Add scope attr to sortable examples

    @dancormier
    dancormier committed May 9, 2023
    Configuration menu
    Copy the full SHA
    d7a1a6b View commit details
    Browse the repository at this point in the history