Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(anchors): add visual, a11y tests #1340

Closed
wants to merge 5 commits into from

Conversation

dancormier
Copy link
Contributor

@dancormier dancormier commented Apr 24, 2023

This PR adds visual and accessibility tests for the s-anchors component. It's pretty straight forward and the only excluded test IDs are within the accessibility tests for default and danger dark mode variants.

TODO

  • Resolve failing tests

@dancormier dancormier requested a review from a team April 24, 2023 20:51
@netlify
Copy link

netlify bot commented Apr 24, 2023

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit c311d13
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/64c94fdac6e0e50008f5d30a
😎 Deploy Preview https://deploy-preview-1340--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dancormier dancormier changed the title test(anchors): add visual, a11y tests for s-anchors test(anchors): add visual, a11y tests Apr 24, 2023
@dancormier dancormier marked this pull request as draft April 25, 2023 21:53
@dancormier
Copy link
Contributor Author

We added these tests in #1404

Closing!

@dancormier dancormier closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant