-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(toggle-switch): apply lower opacity when disabled #1402
Conversation
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@dancormier out of curiosity why we changed so many unrelated baseline images as part of this PR? |
I'm not sure.Looks like when I run I'm gonna dig into commits between the last time we've updated the images and now to see if there's any change that might have caused this.. |
I went back to the last time baseline images were updated (a813110), tried another update, and saw the same thrashing. My initial theory is that an OS or browser update has modified how these components get rendered, but that theory might not explain why tests are failing via GitHub actions. I'm going to open a new PR that includes regenerated baseline images and see if it resolves test failures and consider merging in those updated images. Expect a PR review request @giamir Edit: I just noticed they're all Chromium images that are getting regenerated, so I'm guessing a browser update included a slight rendering update 🤷♂️ |
This PR applies the disabled element opacity to
s-toggle-switch
components. Previously, the disabled state forinput[type="checkbox].s-toggle-switch
would result in no visual changes.Before
After