Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(banner): derive placement from topbar height #1408

Merged
merged 7 commits into from
Jul 7, 2023
Merged

fix(banner): derive placement from topbar height #1408

merged 7 commits into from
Jul 7, 2023

Commits on Jul 6, 2023

  1. Move banner to sit just under the top bar

    @connellsharp
    connellsharp committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ab539de View commit details
    Browse the repository at this point in the history

  2. Use --_no-x-offset as a base offset multiplier

    @dancormier
    dancormier committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    2b07c84 View commit details
    Browse the repository at this point in the history

  3. Remove top border from banner

    @dancormier
    dancormier committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    30b2065 View commit details
    Browse the repository at this point in the history

  4. Update .is-pinned state to use --_no-x-offset 

    Now, it's placed inside `&[aria-hidden="false"]` to prevent cascade conflicts
    @dancormier
    dancormier committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    3d1325d View commit details
    Browse the repository at this point in the history

  5. Update docs to use --theme-topbar-height 

    gtfo custom docs junk
    @dancormier
    dancormier committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    94b80d6 View commit details
    Browse the repository at this point in the history

  6. Update test images 

    That border change shifted all banner test images 1px
    @dancormier
    dancormier committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    f00b405 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Remove docs topbar static height atomic class

    @dancormier
    dancormier committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    a37f015 View commit details
    Browse the repository at this point in the history