-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(button): design refinements #1421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancormier
added
do-not-merge
Pull requests that are in progress and should not be merged yet
work-in-progress
A work in progress, not meant to merge
labels
Jul 17, 2023
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
We have > 1000 button test image and THE TOOLTIP TEST IMAGE FAILS. All the button ones pass. Guess I shouldn't complain!
They're not failing but it seems like a good time to update them
PiperLawson
approved these changes
Jul 24, 2023
dancormier
removed
do-not-merge
Pull requests that are in progress and should not be merged yet
work-in-progress
A work in progress, not meant to merge
labels
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STACKS-339
This PR implements button design refinements as part of the design vision changes to Stacks. cc @PiperLawson
How to test
Hit up the buttons docs page in the deploy preview. The buttons should match the Figma design spec at the end of this PR description. Test out combinations of light/dark and high contrast modes.
TODO
Details about changes in this PR
Figma