Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(visual-regression): update playwright image #1528

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

dancormier
Copy link
Contributor

@dancormier dancormier commented Oct 17, 2023

Chromium baseline images were failing to generate with errors like this:

🚧 Browser logs:
      TypeError: Failed to fetch dynamically imported module: http://localhost:8000/lib/components/input-fill/input-fill.visual.test.ts?wtr-session-id=HL-L1ei9xj185Mzzp-gTR

 ❌ Could not import your test module. Check the browser logs or open the browser in debug mode for more information.

Upgrading the playwright image resolved the issue 🎉

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit a4e1aee
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/652ec3f7ca838a0008c67354
😎 Deploy Preview https://deploy-preview-1528--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dancormier dancormier marked this pull request as ready for review October 17, 2023 17:56
@dancormier dancormier merged commit b2848d7 into develop Oct 17, 2023
@dancormier dancormier deleted the dcormier/update-docker-playwright branch October 17, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant