Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight.js update + new theme classes #551

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Conversation

b-kelly
Copy link
Collaborator

@b-kelly b-kelly commented Nov 10, 2020

This is a draft PR exploring how we might take advantage of the new classes / syntax fixes that the most recent version of highlight.js has added.

Something I'd like to explore in this PR are some possible changes to the LaTeX theme. The tex community was not terribly happy with the new syntax highlighting/theme, so they took it upon themselves to contribute better highlighting detection upstream. I'd love to support these new classes so their hard work doesn't go to waste. They have a post here with suggestions on how to incorporate some of the changes into a new theme.

Changes

I've explicitly added highlight.js as a devDependency so we can tell what version our styles are being built against. I've also added a few of the unused classes to the _stacks-code-block with a TODO comment on them, as well as a LaTeX code example to the docs.

@aaronshekey
Copy link
Contributor

Awesome! Excited to dig into the new classes. I think this all looks super good, and TeX is improved out of the box already.

@schtandard
Copy link

Is this still being pursued? We (meaning the TeX.sx community) might have gone quiet about this but I don't think it's because we don't want our old color scheme back but rather out of resignation. If you are working on something and need feedback, I'm sure we'll be happy to assist.

@netlify
Copy link

netlify bot commented May 23, 2022

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit aef96b9
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/628bc9294660890009ccb3fb
😎 Deploy Preview https://deploy-preview-551--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants