Add API key support to st2client #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +37,7 @@ | |||
|
|
|||
| class Client(object): | |||
| def __init__(self, base_url=None, auth_url=None, api_url=None, api_version=None, cacert=None, | |||
| debug=False, token=None): | |||
| debug=False, token=None, apikey=None): | |||
There was a problem hiding this comment.
For consistency, I think it would be better to call it api_key (that way it's consistent with other variable names).
There was a problem hiding this comment.
I was under the impression it would be inconsistent with variable name in some other place, but I went and checked and could not find one. So here you go.
enykeev
force-pushed
the
feature/client_api_key
branch
from
17d69d3
to
183519a
Compare
|
@Kami so do I have a green light on that one? |
|
LGTM, +1 Please also open a corresponding st2docs PR (I believe there should already be a chapter / section on CLI config somewhere). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in StackStorm/st2-packages#283, the PR adds support for API key to st2client and allows user to store said key in
~/.st2/config.