Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing api.max_page_size to config as IntOpt #6134

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

maxfactor1
Copy link
Contributor

Background

This is a minor fix request to add the 'api.max_page_size' option to the config

Overview of this PR

This request allows the api.max_page_size config option to be used as intended by expressly defining the option, and a default value of '100' in config. Fix submitted to resolve issue #5327

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Feb 13, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ maxfactor1
❌ Maxwell Buehler


Maxwell Buehler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ maxfactor1
❌ Maxwell Buehler


Maxwell Buehler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@guzzijones
Copy link
Contributor

multiple failed tests here. did you recreate the config?

@maxfactor1
Copy link
Contributor Author

Honestly unsure what that's all about. The change was pretty tiny, what config would need to be re-created?

@guzzijones
Copy link
Contributor

make requirements should remake the configs

@fdrab
Copy link
Contributor

fdrab commented Sep 11, 2024

the api.max_page_size was added into the config in #6218 that was merged today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sensor raises Error when using sensor_service.list_values
4 participants