Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 to 3.11 mongo 7.0 #6236

Open
wants to merge 116 commits into
base: master
Choose a base branch
from

Conversation

guzzijones
Copy link
Contributor

python 3.12 works. mongodb 7.0 works.
I also fixed some unit tests.
This merges in @FileMagic and @nzlosh work on mongo 7.0.

@guzzijones
Copy link
Contributor Author

@nzlosh @cognifloyd this is now passing testing. pytest doesn't offer a way to split tests so I removed chunk 1 chunk 2, etc.

@guzzijones
Copy link
Contributor Author

guzzijones commented Sep 12, 2024

chunk1 and chunk2 were running the exact same tests from what I can tell. I don't see any usage of NODE_TOTAL or NODE_INDEX in our workflow code or testing code.

@cognifloyd
Copy link
Member

chunk1 and chunk2 were running the exact same tests from what I can tell. I don't see any usage of NODE_TOTAL or NODE_INDEX in our workflow code or testing code.

The switch to pytest makes those vars obsolete. They were used by nose-parallel: https://pypi.org/project/nose-parallel/

@cognifloyd
Copy link
Member

I'm going to slowly review this PR. I plan to look for isolated pieces of this PR that could go in separate PRs to make each bit of functionality easier to review and check for completeness. I understand that breaking up a large PR can be painful, so I'll try to minimize that pain as much as I can.

@guzzijones
Copy link
Contributor Author

guzzijones commented Sep 13, 2024 via email

@guzzijones guzzijones changed the title Python 3.8 to 3.12 mongo 7.0 Python 3.8 to 3.11 mongo 7.0 Sep 13, 2024
requirements.txt Outdated Show resolved Hide resolved
@guzzijones guzzijones self-assigned this Sep 13, 2024
cognifloyd added a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL PR that changes 1000+ lines. You should absolutely split your PR into several.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants