Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.7.0: update hubot-stackstorm to 0.12.0 #175

Merged
merged 5 commits into from
May 1, 2022
Merged

Conversation

cognifloyd
Copy link
Member

The new hubot-stackstorm release includes StackStorm/hubot-stackstorm#214

@cognifloyd cognifloyd added this to the 3.7.0 milestone Apr 30, 2022
@cognifloyd cognifloyd self-assigned this Apr 30, 2022
@cognifloyd cognifloyd requested a review from nzlosh April 30, 2022 21:44
@@ -21,7 +21,7 @@
"hubot-scripts": "^2.17.2",
"hubot-slack": "^4.5.5",
"hubot-spark": "git+https://github.com/tonybaloney/hubot-spark.git#c440504",
"hubot-stackstorm": "^0.11.3",
"hubot-stackstorm": "^0.12.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also update the npm-shrinkwrap.json lock file so the new version will be really installed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation on how to do that properly is here: #104
Pinned the issue again as it's not the first time it's missed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Hopefully it works.

Why did npm add this weird file dep? who knows.
Just delete it and see if that fixes things.
@cognifloyd
Copy link
Member Author

OK. Build is passing after cleaning up the shrinkwrap file manually in 223f6db - It was somehow picking up a skills-validator dep as a file dep for msteams. That's not listed in https://www.npmjs.com/package/botbuilder/v/3.30.0 dependencies so I just deleted that from npm-shrinkwrap.json.

@cognifloyd cognifloyd requested a review from arm4b April 30, 2022 23:44
@cognifloyd cognifloyd merged commit 9234cbd into master May 1, 2022
@cognifloyd cognifloyd deleted the bump-hubot-stackstorm branch May 1, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants