Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's upgrade to node 6 #78

Merged
merged 14 commits into from
Aug 17, 2017
Merged

Let's upgrade to node 6 #78

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
95cef06
Let's upgrade to node 6
Jul 12, 2017
2ca2b0e
Set node version in package version to node > 6.0.0
Jul 12, 2017
2eed9aa
Use node 6.11.1-slim in Dockerfile
Jul 18, 2017
f8cb388
Packaging and testing env to use node 6.x
Jul 18, 2017
2d09a69
Merge branch 'master' into issue_68/upgrade_to_node_6
Aug 15, 2017
c92dac1
Fix rpm nodejs package requirements
Aug 15, 2017
d418667
Fix deb nodejs package requirements
Aug 15, 2017
6dce22f
Merge branch 'master' into issue_68/upgrade_to_node_6
Aug 16, 2017
a773fcb
Temporary build the package based on hubot-stackstorm PR
Aug 17, 2017
ba655c3
Add 'libicu' dev package, required for the build
Aug 17, 2017
7babeaf
Revert "Temporary build the package based on hubot-stackstorm PR"
Aug 17, 2017
aec5af4
Use update hubot-stackstorm 0.6.0
Aug 17, 2017
1244bb0
Update hubot-irc to 0.2.9
Aug 17, 2017
9aed887
Update npm package dependencies lock
Aug 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:4.2.2-slim
FROM node:6.11.1-slim

RUN apt-get update && apt-get install -y \
python \
Expand Down
2 changes: 1 addition & 1 deletion debian/control
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Vcs-Browser: https://github.com/stackstorm/st2chatops
Package: st2chatops
Architecture: any
Pre-Depends: dpkg (>= 1.16.16)
Depends: nodejs (>= 4.0.0)
Depends: nodejs (>= 6.0.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering nodejs epopeya https://github.com/StackStorm/ops-infra/pull/206, please pin node versions to 6 for both deb/rpm.
So we won't install any node7 or node8 or whatever in future.

Description: St2Chatops - StackStorm ChatOps.
Package providing StackStorm ChatOps functionality: bundled, tested and ready to use Hubot
with hubot-stackstorm plugin and additional chat adapters
2 changes: 2 additions & 0 deletions debian/st2chatops.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ TimeoutSec=60
PrivateTmp=true
Restart=on-failure
RestartSec=5
StandardOutput=syslog+console
StandardError=syslog+console
Copy link
Member

@arm4b arm4b Jul 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that fix hubot logging bug described here: StackStorm/st2-packages#300 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not. This directive instructs journalctl to write to console which should get logged to /var/log according to docs but it doesn't. So sad.

Copy link
Member

@arm4b arm4b Jul 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this param, feels like the truth is out there.

Let's try this for st2chatops.service:

- ExecStart=/opt/stackstorm/chatops/bin/hubot $DAEMON_ARGS
+ ExecStart=exec bin/hubot $DAEMON_ARGS >> /var/log/st2/st2chatops.log 2>&1


[Install]
WantedBy=multi-user.target
Loading