(Re)Save workflow/Workflow Designer Text #355
Conversation
This commit fixes a bug in saving a new workflow after its initial save. The bug was caused by the check done to see if the workflow is new or not. When flow is loaded it downloads a list of actions. This list is checked to see if the action is new or not. Once the initial save happens the actions were not refreshed, thus the API call was always a POST instead of an initial POST followed by a PUT. This commit refreshes actions after the initial save.
The top menu has workflow designer text as a subscript. This commit aligns it even with the logo.
|
I confirmed re-save now works correctly 👍 There is still a small race (you still get error if you press save two times in a row really fast before it has the chance to re-fetch the action), but that's not a big deal. Future optimization would probably be to grey out save button (or not allow for it to be pressed until the green color goes away) until we re-fetch the action / similar, but not a big deal for now. |
|
So yeah, digging in some more on the issue mentioned above - we fetch all the actions on successful save using overview API endpoint which can be quite slowish if there are a lot of actions in the system (3-5 seconds on install with examples pack installed) so I think disabling "save" button until save operation completes (when green color switches off) would be a good thing to do. |
This PR fixes new workflow re-save (see commit for details) and sub-text misalignment.
Fixes #353
Fixes #352
Fixes #342