-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create design system package #2
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 5
Lines ? 34
Branches ? 10
========================================
Hits ? 34
Misses ? 0
Partials ? 0
Continue to review full report in Codecov by Sentry.
|
34a7544
to
db9300a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job with the changes and the start of the design system. It will be great to have that as a reusable set of components for multiple projects in the future!
In some conversations with @vishnuravi and @NikolaiMadlener we discussed it it makes sense to utilize and build on top of something like https://ui.shadcn.com/docs for the different components as a head start if needed.
They seem to be MIT licensed and therefore easily integrated with a proper acknowledgement.
Would be great to hear your thoughts on the advantages/disadvantages and if that might be useful for some elements?
Yes, I will be using shadcn/ui as starting point for many components. It's a great, modern library with a lot of good practices baked in. There are basically no disadvantages. I've been using shadcn/ui and Radix headless lib for a long time and I consider it best way to build. |
db9300a
to
86d6933
Compare
Create design system package
♻️ Current situation & Problem
We need separate package with design system components and instructions to reuse.
⚙️ Release Notes
📚 Documentation
Button
component with storybook, tests, cva. Blueprint for future componentsCode of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: