New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix location error propagation #55

Merged

vishnuravi merged 4 commits into main from update-fetch

Jan 11, 2025

Member

vishnuravi commented Jan 11, 2025 •

edited

Loading

Fix location error propagation

Location data fetching errors generated by the Standard are currently not being propagated back to the LocationModule, so the user is not informed. This PR makes sure errors are propagated such that the user can be notified if location data fetching fails.
The PR also removes a redundant location data fetch.

vishnuravi added 2 commits

January 11, 2025 12:07


          Update fetching logic

53a5e7b


          Merge branch 'main' of https://github.com/StanfordBDHG/LifeSpace into…

06f5fde

… update-fetch

vishnuravi changed the title ~~Update location fetching logic~~ Fix location error propagation

vishnuravi added 2 commits

January 11, 2025 14:41


          Rollback

06adabd


          Update alert

2337f92

vishnuravi merged commit 2037bac into main

3 checks passed

vishnuravi deleted the update-fetch branch

January 11, 2025 22:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet