Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .idea to Git ignore #17

Merged

Conversation

arkadiuszbachorski
Copy link
Contributor

Add .idea to Git ignore

♻️ Current situation & Problem

.idea is directory that stores per-project configuration of JetBrains IDEs. It shouldn't be versioned.

⚙️ Release Notes

  • Add .idea to Git ignore

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arkadiuszbachorski! 🚀

@PSchmiedmayer
Copy link
Member

@arkadiuszbachorski I have fixed the eslint issues by updating our reusable GitHub Action to handle the state when we run the PRs from a fork, they all pass in the other PRs. Unfortunately re-running the GitHub Action here remembers the old version tag it used in the initial run (makes sense to make that reproducible) and therefore doesn't pick up the new change.

In addition @codecov seems to have run into an issue where they reached their GitHub rate limit: https://github.com/StanfordBDHG/NextJSTemplate/actions/runs/9289714498/job/25574778071?pr=17#step:6:34.

As we can't share a secret with a forked repo and they seem to struggle with that for a while I could see two options:

  1. Create the PRs (or merge them in one PR in this repo by creating a branch)
  2. I merge the PRs with my admin permissions.

I will go for (2) for now and will merge them in a sequential order.

@PSchmiedmayer PSchmiedmayer merged commit 7861486 into StanfordBDHG:main May 29, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants