Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use screen instead of destructing render #21

Conversation

arkadiuszbachorski
Copy link
Contributor

Use screen instead of destructing render

♻️ Current situation & Problem

Destructing render to get selectors binds result of render to selectors. Sometimes it's unwanted, especially if creating some reusable functions across the tests.

This binding is completely unnecessary, doesn't benefit tests readability and ease of development. It's easier to use screen everywhere, because of auto-completion and lack of maintenance of destructed properties.

⚙️ Release Notes

  • Use screen instead of destructing render

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arkadiuszbachorski; looks good to me!

@vishnuravi
Copy link
Member

This is a nice improvement - thanks @arkadiuszbachorski!

@PSchmiedmayer PSchmiedmayer merged commit 5ce0539 into StanfordBDHG:main May 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants