Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NCI Trial API type error, update used GPT models, fix warnings and deprecations, Swift 6 language mode concurrency compatibility #29

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

philippzagar
Copy link
Collaborator

Fix NCI Trial API type error, update used GPT models, fix warnings and deprecations, Swift 6 language mode concurrency compatibility

♻️ Current situation & Problem

The current state of the application requires a bit of maintenance to keep up with Swift evolution as well as the rest of the Spezi ecosystem. Outdated OpenAI GPT models are used. OpenAPI generated NCI Trial API contains a type error for a property of a response, leading to possible decoding errors

⚙️ Release Notes

  • Fix NCI Trial API type error
  • Update used GPT models
  • Fix warnings and deprecations
  • Swift 6 language mode concurrency compatibility

📚 Documentation

--

✅ Testing

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

…d deprecations, Swift 6 language mode concurrency compatibility
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 56.41026% with 17 lines in your changes missing coverage. Please review.

Project coverage is 18.86%. Comparing base (13ecfbc) to head (33c96b7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
OwnYourData/OwnYourDataStandard.swift 0.00% 12 Missing ⚠️
OwnYourData/TrialsMatching/MatchingModule.swift 20.00% 4 Missing ⚠️
...lsMatching/LLMFunctions/GetTrialsLLMFunction.swift 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   18.37%   18.86%   +0.49%     
==========================================
  Files          59       59              
  Lines        1998     2010      +12     
==========================================
+ Hits          367      379      +12     
  Misses       1631     1631              
Files with missing lines Coverage Δ
OwnYourData/ClinicalTrials/NCITrialsModule.swift 8.46% <100.00%> (ø)
...ata/ClinicalTrials/NICTrialsAPIDateFormatter.swift 0.00% <ø> (ø)
...Data/ClinicalTrials/TrialDetail+Identifiable.swift 0.00% <ø> (ø)
...nYourData/Documents/PDFDocument+Transferable.swift 0.00% <ø> (ø)
...ourData/Helper/CodableArray+RawRepresentable.swift 0.00% <ø> (ø)
OwnYourData/Home.swift 80.00% <100.00%> (ø)
OwnYourData/OwnYourDataDelegate.swift 95.09% <100.00%> (-1.10%) ⬇️
...lsMatching/LLMFunctions/GetTrialsLLMFunction.swift 0.00% <0.00%> (ø)
OwnYourData/TrialsMatching/MatchingModule.swift 12.29% <20.00%> (-0.10%) ⬇️
OwnYourData/OwnYourDataStandard.swift 7.28% <0.00%> (+0.26%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ecfbc...33c96b7. Read the comment docs.

@philippzagar
Copy link
Collaborator Author

Merging this as @PSchmiedmayer already approved the fork's PR in #28

@philippzagar philippzagar merged commit 13138e9 into main Nov 12, 2024
11 of 12 checks passed
@philippzagar philippzagar deleted the feat/minor-improvements branch November 12, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant