-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow assignment operations on regions in Regent #583
Open
ldr709
wants to merge
8
commits into
StanfordLegion:master
Choose a base branch
from
ldr709:regent-dataflow-unique-region-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allow assignment operations on regions in Regent #583
ldr709
wants to merge
8
commits into
StanfordLegion:master
from
ldr709:regent-dataflow-unique-region-types
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
writes(a) and reads(a.x) should be sufficient to grant reduces(a.x), but a bug makes this test case fail.
magnatelee
added
enhancement
planned
Feature/fix to be actively worked on - needs release target
Regent
Issues pertaining to Regent
labels
Dec 6, 2019
This was referenced Mar 26, 2020
@elliottslaughter @magnatelee what's the plan for this? |
I think @magnatelee looked at this and I believe our concern was about compile times. I think it's still very desirable feature but just haven't had time to look in detail at what the impact on compile times is and whether it can be mitigated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
planned
Feature/fix to be actively worked on - needs release target
Regent
Issues pertaining to Regent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready for merge. Issues:
Doesn't support
__fields
or__physical
. It would need to know the privileges on the fields during type checking, but that information is now calculated later. Breaking the circular dependency probably wouldn't be too difficult, but it would be annoying to have to go back and fix up the type checked AST after finding the privileges. One failing test case isrun_pass/call_terra_region.rg
.Index launch checking is less complete. I didn't get around to implementing the check to see if two regions are always distinct for all pairs of iterations. This would just need some metadata to tell if a parent region was declared outside the loop. A failing test case is
run_pass/optimize_index_launch_num.rg
.flow_from_ast.t
still tries to use the old constraint data, even though it isn't there anymore. It hasn't been converted to using the new interface for getting constraint information. This makesrun_pass/parallelize_tasks_hint_color_space.rg
fail, among others.