Skip to content

Commit

Permalink
[Enhancement] upgrade jmockit & jcoco to support jdk11 or later (#23445)
Browse files Browse the repository at this point in the history
there is conflicting with jdk11 + jmockit + jcoco0.85, and more details in
jmockit/jmockit1#665
jmockit/jmockit1#615

Signed-off-by: zombee0 <[email protected]>
  • Loading branch information
zombee0 authored May 16, 2023
1 parent 1b02e68 commit 2f3ed5a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 8 deletions.
9 changes: 5 additions & 4 deletions fe/fe-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ under the License.
<properties>
<starrocks.home>${basedir}/../../</starrocks.home>
<fe_ut_parallel>${env.FE_UT_PARALLEL}</fe_ut_parallel>
<jacoco.version>0.8.5</jacoco.version>
<jacoco.version>0.8.7</jacoco.version>
<iceberg.version>1.1.0</iceberg.version>
<awsv2.version>2.17.257</awsv2.version>
<python>python</python>
Expand Down Expand Up @@ -179,8 +179,9 @@ under the License.
</dependency>

<!-- https://mvnrepository.com/artifact/org.jmockit/jmockit -->
<!-- https://mvnrepository.com/artifact/com.github.hazendaz.jmockit/jmockit -->
<dependency>
<groupId>org.jmockit</groupId>
<groupId>com.github.hazendaz.jmockit</groupId>
<artifactId>jmockit</artifactId>
<scope>test</scope>
</dependency>
Expand Down Expand Up @@ -783,7 +784,7 @@ under the License.
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>0.8.5</version>
<version>0.8.7</version>
<executions>
<execution>
<id>default-prepare-agent</id>
Expand Down Expand Up @@ -883,7 +884,7 @@ under the License.
<!-->not reuse forked jvm, so that each unit test will run in separate jvm. to avoid singleton confict<-->
<reuseForks>false</reuseForks>
<argLine>
-javaagent:${settings.localRepository}/org/jmockit/jmockit/1.48/jmockit-1.48.jar -Xmx2048m
-javaagent:${settings.localRepository}/com/github/hazendaz/jmockit/jmockit/1.49.4/jmockit-1.49.4.jar -Xmx2048m
-Duser.timezone=Asia/Shanghai @{jacocoArgLine}
</argLine>
<!-- Set maven to use independent class loading to avoid unit test failure due to the early shutdown of the JVM -->
Expand Down
5 changes: 3 additions & 2 deletions fe/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -296,10 +296,11 @@ under the License.
</dependency>

<!-- https://mvnrepository.com/artifact/org.jmockit/jmockit -->
<!-- https://mvnrepository.com/artifact/com.github.hazendaz.jmockit/jmockit -->
<dependency>
<groupId>org.jmockit</groupId>
<groupId>com.github.hazendaz.jmockit</groupId>
<artifactId>jmockit</artifactId>
<version>1.48</version>
<version>1.49.4</version>
<scope>test</scope>
</dependency>

Expand Down
5 changes: 3 additions & 2 deletions fe/spark-dpp/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,9 @@ under the License.
</dependency>

<!-- https://mvnrepository.com/artifact/org.jmockit/jmockit -->
<!-- https://mvnrepository.com/artifact/com.github.hazendaz.jmockit/jmockit -->
<dependency>
<groupId>org.jmockit</groupId>
<groupId>com.github.hazendaz.jmockit</groupId>
<artifactId>jmockit</artifactId>
<scope>test</scope>
</dependency>
Expand Down Expand Up @@ -178,7 +179,7 @@ under the License.
<!-->not reuse forked jvm, so that each unit test will run in separate jvm. to avoid singleton confict<-->
<reuseForks>false</reuseForks>
<argLine>
-javaagent:${settings.localRepository}/org/jmockit/jmockit/1.48/jmockit-1.48.jar
-javaagent:${settings.localRepository}/com/github/hazendaz/jmockit/jmockit/1.49.4/jmockit-1.49.4.jar
</argLine>
</configuration>
</plugin>
Expand Down

0 comments on commit 2f3ed5a

Please sign in to comment.