add test case

Signed-off-by: before-Sunrise <[email protected]>
StarRocks · Jul 21, 2024 · dd80169 · dd80169
1 parent bd52779
commit dd80169
Show file tree

Hide file tree

Showing 6 changed files with 630 additions and 1 deletion.
diff --git a/fe/fe-core/src/main/java/com/starrocks/planner/HashJoinNode.java b/fe/fe-core/src/main/java/com/starrocks/planner/HashJoinNode.java
@@ -77,7 +77,7 @@ public HashJoinNode(PlanNodeId id, PlanNode outer, PlanNode inner, JoinOperator
     }
 
     public boolean isSkewJoin() {
-        return isSkewJoin;
+        return isSkewJoin && ConnectContext.get().getSessionVariable().isEnableOptimizerSkewJoinByBroadCastSkewValues();
     }
 
     public void setSkewJoin(boolean skewJoin) {

diff --git a/fe/fe-core/src/test/java/com/starrocks/sql/plan/SkewJoinTest.java b/fe/fe-core/src/test/java/com/starrocks/sql/plan/SkewJoinTest.java
@@ -41,6 +41,8 @@ public static void beforeClass() throws Exception {
         connectContext.getGlobalStateMgr().setStatisticStorage(new MockHistogramStatisticStorage(scale));
         GlobalStateMgr globalStateMgr = connectContext.getGlobalStateMgr();
         connectContext.getSessionVariable().setEnableStatsToOptimizeSkewJoin(true);
+        connectContext.getSessionVariable().setEnableOptimizerSkewJoinByQueryRewrite(true);
+        connectContext.getSessionVariable().setEnableOptimizerSkewJoinByBroadCastSkewValues(false);
 
         OlapTable t0 = (OlapTable) globalStateMgr.getDb("test").getTable("region");
         setTableStatistics(t0, 5);

diff --git a/test/sql/test_join/R/test_skew_join b/test/sql/test_join/R/test_skew_join
@@ -41,6 +41,12 @@ PROPERTIES (
 );
 -- result:
 -- !result
+set enable_optimize_skew_join_by_query_rewrite=true;
+-- result:
+-- !result
+set enable_optimize_skew_join_by_broadcast_skew_values=false;
+-- result:
+-- !result
 truncate table t1;
 -- result:
 -- !result