Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix column overflow when handle too large partial update (backport #49054) #49478

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 7, 2024

Why I'm doing:

In current implementation, when handle partial column update, we will try to build the column to be updated with segment granularity, it will lead to overflow. E.g.

  1. If we have a ARRAY column to be update, In the beginning, because the data in the table does not contain arrays yet, we will slice the segment file with a size of 1GB, so a segment file may contain a large number of rows. We can assume that there are 500w rows in a tablet.
  2. And in a ArraryColumn struct, we store offset of array using uint32_t , that means we can only have 4,294,967,295 items in a ArraryColumn.
  3. When items in one array is larger than 900, which is large than 4,294,967,295, so overflow happens.

What I'm doing:

Processing updates involving large amounts of data in batches, each batch will be limit by partial_update_memory_limit_per_worker.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #49054 done by [Mergify](https://mergify.com). ## Why I'm doing: In current implementation, when handle partial column update, we will try to build the column to be updated with segment granularity, it will lead to overflow. E.g. 1. If we have a `ARRAY` column to be update, In the beginning, because the data in the table does not contain arrays yet, we will slice the segment file with a size of 1GB, so a segment file may contain a large number of rows. We can assume that there are 500w rows in a tablet. 2. And in a `ArraryColumn` struct, we store offset of array using uint32_t , that means we can only have 4,294,967,295 items in a `ArraryColumn`. 3. When items in one array is larger than 900, which is large than 4,294,967,295, so overflow happens.

What I'm doing:

Processing updates involving large amounts of data in batches, each batch will be limit by partial_update_memory_limit_per_worker.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…9054)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 3b682c7)

# Conflicts:
#	be/src/storage/rowset/rowset.h
#	be/src/storage/rowset_column_update_state.cpp
#	gensrc/proto/olap_file.proto
@mergify mergify bot added the conflicts label Aug 7, 2024
Copy link
Contributor Author

mergify bot commented Aug 7, 2024

Cherry-pick of 3b682c7 has failed:

On branch mergify/bp/branch-3.2/pr-49054
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit 3b682c7027.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/common/config.h
	modified:   be/src/storage/rowset/horizontal_update_rowset_writer.cpp
	modified:   be/src/storage/rowset/rowset_meta.h
	modified:   be/src/storage/rowset/rowset_writer.cpp
	modified:   be/src/storage/rowset_column_update_state.h
	modified:   be/test/storage/rowset_column_partial_update_test.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/storage/rowset/rowset.h
	both modified:   be/src/storage/rowset_column_update_state.cpp
	both modified:   gensrc/proto/olap_file.proto

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) August 7, 2024 05:54
@mergify mergify bot closed this Aug 7, 2024
auto-merge was automatically disabled August 7, 2024 05:55

Pull request was closed

Copy link
Contributor Author

mergify bot commented Aug 7, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.2/pr-49054 branch August 7, 2024 05:55
@luohaha luohaha restored the mergify/bp/branch-3.2/pr-49054 branch August 7, 2024 17:30
@luohaha luohaha reopened this Aug 7, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) August 7, 2024 17:31
Signed-off-by: Yixin Luo <[email protected]>
Copy link

sonarcloud bot commented Aug 7, 2024

@wanpengfei-git wanpengfei-git merged commit 2d79dc7 into branch-3.2 Aug 7, 2024
29 of 30 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-49054 branch August 7, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants