[BugFix] fix column overflow when handle too large partial update #49054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luohaha <[email protected]>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
Signed-off-by: luohaha <[email protected]>
chaoyli
reviewed
Jul 30, 2024
decster
previously approved these changes
Aug 2, 2024
chaoyli
previously approved these changes
Aug 5, 2024
wyb
reviewed
Aug 6, 2024
Signed-off-by: luohaha <[email protected]>
|
wyb
approved these changes
Aug 7, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 44 / 48 (91.67%) file detail
|
decster
approved these changes
Aug 7, 2024
kevincai
approved these changes
Aug 7, 2024
dirtysalt
approved these changes
Aug 7, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
…9054) Signed-off-by: luohaha <[email protected]> (cherry picked from commit 3b682c7) # Conflicts: # gensrc/proto/olap_file.proto
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
…9054) Signed-off-by: luohaha <[email protected]> (cherry picked from commit 3b682c7) # Conflicts: # be/src/storage/rowset/rowset.h # be/src/storage/rowset_column_update_state.cpp # gensrc/proto/olap_file.proto
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 7, 2024
…ckport #49054) (#49478) Signed-off-by: Yixin Luo <[email protected]> Co-authored-by: Yixin Luo <[email protected]>
luohaha
added a commit
that referenced
this pull request
Aug 8, 2024
…ckport #49054) (#49477) Signed-off-by: Yixin Luo <[email protected]> Co-authored-by: Yixin Luo <[email protected]>
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In current implementation, when handle partial column update, we will try to build the column to be updated with segment granularity, it will lead to overflow. E.g.
ARRAYcolumn to be update, In the beginning, because the data in the table does not contain arrays yet, we will slice the segment file with a size of 1GB, so a segment file may contain a large number of rows. We can assume that there are 500w rows in a tablet.ArraryColumnstruct, we store offset of array using uint32_t , that means we can only have 4,294,967,295 items in aArraryColumn.What I'm doing:
Processing updates involving large amounts of data in batches, each batch will be limit by
partial_update_memory_limit_per_worker.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: