Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UT] Remove BeRestartNewPublishTest (backport #43242) #43252

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 27, 2024

Why I'm doing:

BeRestartNewPublishTest takes long time to run, and there is already a BeRestartTest with similar function, and new publish is not actively used.

What I'm doing:

Remove BeRestartNewPublishTest

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #43242 done by [Mergify](https://mergify.com). ## Why I'm doing:

BeRestartNewPublishTest takes long time to run, and there is already a BeRestartTest with similar function, and new publish is not actively used.

What I'm doing:

Remove BeRestartNewPublishTest

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link
Contributor Author

mergify bot commented Mar 27, 2024

Cherry-pick of 71f8a4c has failed:

On branch mergify/bp/branch-2.5/pr-43242
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 71f8a4cf67.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: fe/fe-core/src/test/java/com/starrocks/pseudocluster/BeRestartNewPublishTest.java

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Mar 27, 2024
@mergify mergify bot mentioned this pull request Mar 27, 2024
23 tasks
@mergify mergify bot closed this Mar 27, 2024
Copy link
Contributor Author

mergify bot commented Mar 27, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-43242 branch March 27, 2024 10:18
@decster decster restored the mergify/bp/branch-2.5/pr-43242 branch April 26, 2024 02:35
@decster decster reopened this Apr 26, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 26, 2024 02:35
Why I'm doing:
BeRestartNewPublishTest takes long time to run, and there is already a BeRestartTest with similar function, and new publish is not actively used.

What I'm doing:
Remove BeRestartNewPublishTest

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 71f8a4c)
@decster decster force-pushed the mergify/bp/branch-2.5/pr-43242 branch from 6d875c0 to d7d1e0d Compare April 26, 2024 02:37
@wanpengfei-git wanpengfei-git merged commit 00282bc into branch-2.5 Apr 26, 2024
30 of 31 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-2.5/pr-43242 branch April 26, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants