Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] check compare optmization more strict (backport #42936) #43345

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 28, 2024

Why I'm doing:

string > 1231, will optimize to string > "1231", but >,<,<=,>= must cast to double

For:
string > 123, must cast to double, can't optimize
string = 123, and cbo_eq_type = decimal, can't optimize
string = 123, and cbo_eq_type = varchar, can be string = "123" , but if follow the normal logical, the result also string = "123" , it's unnecessary

What I'm doing:

Fixes #40619

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #42936 done by [Mergify](https://mergify.com). ## Why I'm doing:

string > 1231, will optimize to string > "1231", but >,<,<=,>= must cast to double

For:
string > 123, must cast to double, can't optimize
string = 123, and cbo_eq_type = decimal, can't optimize
string = 123, and cbo_eq_type = varchar, can be string = "123" , but if follow the normal logical, the result also string = "123" , it's unnecessary

What I'm doing:

Fixes #40619

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: Seaven <[email protected]>
(cherry picked from commit a04b659)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/scalar/ImplicitCastRule.java
#	fe/fe-core/src/test/resources/sql/subquery/in-subquery.sql
#	fe/fe-core/src/test/resources/sql/subquery/scalar-subquery.sql
#	test/sql/test_multi_ops/R/test_depends_ops
@mergify mergify bot added the conflicts label Mar 28, 2024
Copy link
Contributor Author

mergify bot commented Mar 28, 2024

Cherry-pick of a04b659 has failed:

On branch mergify/bp/branch-2.5/pr-42936
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit a04b659a9a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/common/TypeManager.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/ExpressionTest.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/scalar/ImplicitCastRule.java
	both modified:   fe/fe-core/src/test/resources/sql/subquery/in-subquery.sql
	both modified:   fe/fe-core/src/test/resources/sql/subquery/scalar-subquery.sql
	deleted by us:   test/sql/test_multi_ops/R/test_depends_ops

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) March 28, 2024 11:18
@mergify mergify bot closed this Mar 28, 2024
auto-merge was automatically disabled March 28, 2024 11:18

Pull request was closed

Copy link
Contributor Author

mergify bot commented Mar 28, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-42936 branch March 28, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant