[Enhancement] check compare optmization more strict (backport #42936) #43345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
string > 1231
, will optimize tostring > "1231"
, but >,<,<=,>= must cast todouble
For:
string > 123
, must cast to double, can't optimizestring = 123
, andcbo_eq_type
= decimal, can't optimizestring = 123
, andcbo_eq_type
= varchar, can bestring = "123"
, but if follow the normal logical, the result alsostring = "123"
, it's unnecessaryWhat I'm doing:
Fixes #40619
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #42936 done by [Mergify](https://mergify.com). ## Why I'm doing:
string > 1231
, will optimize tostring > "1231"
, but >,<,<=,>= must cast todouble
For:
string > 123
, must cast to double, can't optimizestring = 123
, andcbo_eq_type
= decimal, can't optimizestring = 123
, andcbo_eq_type
= varchar, can bestring = "123"
, but if follow the normal logical, the result alsostring = "123"
, it's unnecessaryWhat I'm doing:
Fixes #40619
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: