Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Disable duplicate sort key when creating table (backport #43206) #43376

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 29, 2024

Why I'm doing:

If we create table with duplicate sort key columns, BE maybe crash. For example:

  1. We create a primary key table with duplicate sort key column (k1,v1,v1).
  2. In vertical compaction, we will first create a schema k1,v1,v1 to read the sort key columns from segment data.
  3. When we create segment_iterator, we will create column_iterator for each column according to the column id. However, the two columns v1 has the same column id, so we only create one column iterator.
  4. During read data, we will generate a chunk with three columns and read data column by column. But the two columns v1 will use the same column iterator to read data and the offset is inconsistent with column k1 and it may cause the rows in different columns in a chunk are inconsistent and this may cause BE crash.

What I'm doing:

Disable duplicate sort key when creating table.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #43206 done by [Mergify](https://mergify.com). ## Why I'm doing: If we create table with duplicate sort key columns, BE maybe crash. For example: 1. We create a primary key table with duplicate sort key column (k1,v1,v1). 2. In vertical compaction, we will first create a schema `k1,v1,v1` to read the sort key columns from segment data. 3. When we create `segment_iterator`, we will create `column_iterator` for each column according to the column id. However, the two columns `v1` has the same column id, so we only create one column iterator. 4. During read data, we will generate a chunk with three columns and read data column by column. But the two columns `v1` will use the same column iterator to read data and the offset is inconsistent with column `k1` and it may cause the rows in different columns in a chunk are inconsistent and this may cause BE crash.

What I'm doing:

Disable duplicate sort key when creating table.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: zhangqiang <[email protected]>
(cherry picked from commit 5312180)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/server/OlapTableFactory.java
#	test/conf/sr.conf
#	test/sql/test_sort_key/R/test_sort_key_agg_tbl
#	test/sql/test_sort_key/R/test_sort_key_dup_tbl
#	test/sql/test_sort_key/R/test_sort_key_uni_tbl
#	test/sql/test_sort_key/T/test_sort_key_agg_tbl
#	test/sql/test_sort_key/T/test_sort_key_dup_tbl
#	test/sql/test_sort_key/T/test_sort_key_uni_tbl
Copy link
Contributor Author

mergify bot commented Mar 29, 2024

Cherry-pick of 5312180 has failed:

On branch mergify/bp/branch-2.5/pr-43206
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 53121805f2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   test/sql/test_sort_key/R/test_sort_key_pri_tbl
	new file:   test/sql/test_sort_key/T/test_sort_key_pri_tbl

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/server/OlapTableFactory.java
	deleted by us:   test/conf/sr.conf
	deleted by us:   test/sql/test_sort_key/R/test_sort_key_agg_tbl
	deleted by us:   test/sql/test_sort_key/R/test_sort_key_dup_tbl
	deleted by us:   test/sql/test_sort_key/R/test_sort_key_uni_tbl
	deleted by us:   test/sql/test_sort_key/T/test_sort_key_agg_tbl
	deleted by us:   test/sql/test_sort_key/T/test_sort_key_dup_tbl
	deleted by us:   test/sql/test_sort_key/T/test_sort_key_uni_tbl

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Mar 29, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-43206 branch March 29, 2024 02:57
@sevev sevev restored the mergify/bp/branch-2.5/pr-43206 branch April 8, 2024 02:21
@sevev sevev reopened this Apr 8, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 8, 2024 02:21
Signed-off-by: zhangqiang <[email protected]>
@sevev sevev closed this Apr 10, 2024
auto-merge was automatically disabled April 10, 2024 03:25

Pull request was closed

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-43206 branch April 10, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant