Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Unpack const column when in local exchange source operator (backport #43403) #43635

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 7, 2024

Why I'm doing:

  • BE may crash when local source exchange operator handle a const column because chunk#append_selective cannot handle const colulmn.
  • And this always happens when chunk is ouptuted by repeat node.

What I'm doing:

  • Introduce unpack_and_duplicate_const_columns method in chunk.
  • Apply unpack_and_duplicate_const_columns in local_exchange_source_operator before chunk#append_selective
  • Consider grouping/grouping_id in RewriteGroupingSetsByCTERule
  • Add more tests.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #43403 done by [Mergify](https://mergify.com). ## Why I'm doing: - BE may crash when local source exchange operator handle a const column because chunk#append_selective cannot handle const colulmn. - And this always happens when chunk is ouptuted by repeat node.

What I'm doing:

  • Introduce unpack_and_duplicate_const_columns method in chunk.
  • Apply unpack_and_duplicate_const_columns in local_exchange_source_operator before chunk#append_selective
  • Consider grouping/grouping_id in RewriteGroupingSetsByCTERule
  • Add more tests.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…43403)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 608e00f)

# Conflicts:
#	be/src/column/chunk.cpp
#	be/src/exec/pipeline/aggregate/repeat/repeat_operator.h
#	be/src/exec/pipeline/exchange/local_exchange_source_operator.cpp
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/RewriteMultiDistinctRule.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/transformer/QueryTransformer.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/PlanFragmentWithCostTest.java
Copy link
Contributor Author

mergify bot commented Apr 7, 2024

Cherry-pick of 608e00f has failed:

On branch mergify/bp/branch-2.5/pr-43403
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 608e00f4bd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/column/chunk.h
	modified:   be/src/exec/pipeline/aggregate/repeat/repeat_operator.cpp
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/RewriteGroupingSetsByCTERule.java
	new file:   fe/fe-core/src/test/java/com/starrocks/sql/plan/GroupingSetsTest.java
	new file:   test/sql/test_grouping_sets/R/test_grouping_sets_v1
	new file:   test/sql/test_grouping_sets/R/test_grouping_sets_v2
	new file:   test/sql/test_grouping_sets/T/test_grouping_sets_v1
	new file:   test/sql/test_grouping_sets/T/test_grouping_sets_v2

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/column/chunk.cpp
	both modified:   be/src/exec/pipeline/aggregate/repeat/repeat_operator.h
	both modified:   be/src/exec/pipeline/exchange/local_exchange_source_operator.cpp
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/RewriteMultiDistinctRule.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/transformer/QueryTransformer.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/PlanFragmentWithCostTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Apr 7, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-43403 branch April 7, 2024 03:03
@LiShuMing LiShuMing restored the mergify/bp/branch-2.5/pr-43403 branch April 7, 2024 07:06
@LiShuMing LiShuMing reopened this Apr 7, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 7, 2024 07:07
Signed-off-by: shuming.li <[email protected]>
Copy link

sonarcloud bot commented Apr 7, 2024

@wanpengfei-git wanpengfei-git merged commit e5f4569 into branch-2.5 Apr 7, 2024
30 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-2.5/pr-43403 branch April 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants