-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Unpack const column when in local exchange source operator (backport #43403) #43635
Conversation
…43403) Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 608e00f) # Conflicts: # be/src/column/chunk.cpp # be/src/exec/pipeline/aggregate/repeat/repeat_operator.h # be/src/exec/pipeline/exchange/local_exchange_source_operator.cpp # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/RewriteMultiDistinctRule.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/transformer/QueryTransformer.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/PlanFragmentWithCostTest.java
Cherry-pick of 608e00f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
Signed-off-by: shuming.li <[email protected]>
Quality Gate passedIssues Measures |
Why I'm doing:
What I'm doing:
unpack_and_duplicate_const_columns
method in chunk.chunk#append_selective
RewriteGroupingSetsByCTERule
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #43403 done by [Mergify](https://mergify.com). ## Why I'm doing: - BE may crash when local source exchange operator handle a const column because chunk#append_selective cannot handle const colulmn. - And this always happens when chunk is ouptuted by repeat node.
What I'm doing:
unpack_and_duplicate_const_columns
method in chunk.chunk#append_selective
RewriteGroupingSetsByCTERule
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: