Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] to_json return null when unsupported #45607

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented May 14, 2024

Why I'm doing:

What I'm doing:

origin:

MySQL td> select to_json(map{null:null});
(1064, 'key of Map should not be null')

update:

MySQL td> select /*+SET_VAR(sql_mode='ONLY_FULL_GROUP_BY,ALLOW_THROW_EXCEPTION')*/ to_json(map{null:null});
(1064, 'key of Map should not be null')
MySQL td> select /*+SET_VAR(sql_mode='ONLY_FULL_GROUP_BY')*/ to_json(map{null:null});
+-------------------------+
| to_json(map{NULL:NULL}) |
+-------------------------+
| <null>                  |
+-------------------------+
0 rows in set

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Seaven Seaven requested a review from a team as a code owner May 14, 2024 11:44
@mergify mergify bot assigned Seaven May 14, 2024
@Seaven
Copy link
Contributor Author

Seaven commented Aug 6, 2024

@mergify rebase

Copy link
Contributor

mergify bot commented Aug 6, 2024

rebase

✅ Branch has been successfully rebased

Copy link

github-actions bot commented Aug 6, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Aug 6, 2024

[BE Incremental Coverage Report]

fail : 12 / 25 (48.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exprs/cast_expr_json.cpp 9 22 40.91% [137, 223, 224, 225, 226, 228, 229, 230, 231, 236, 237, 242, 243]
🔵 be/src/exprs/function_context.cpp 2 2 100.00% []
🔵 be/src/exprs/json_functions.cpp 1 1 100.00% []

@Seaven Seaven enabled auto-merge (squash) August 6, 2024 08:54
@kangkaisen kangkaisen merged commit b58b8a2 into StarRocks:main Aug 6, 2024
40 of 41 checks passed
Seaven added a commit to Seaven/starrocks that referenced this pull request Aug 22, 2024
@Seaven
Copy link
Contributor Author

Seaven commented Aug 22, 2024

@mergify backport branch-3.3

Copy link
Contributor

mergify bot commented Aug 22, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants