Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] release metadata memory after rowsets have been compacted in pk table (backport #46067) #46303

Merged
merged 2 commits into from
May 27, 2024
Merged

[Enhancement] release metadata memory after rowsets have been compacted in pk table (backport #46067) #46303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d6513e
[Enhancement] release metadata memory after rowsets have been compact…
luohaha May 27, 2024
92d2879
resolve
luohaha May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions be/src/storage/tablet_updates.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1789,9 +1789,13 @@ Status TabletUpdates::_do_compaction(std::unique_ptr<CompactionInfo>* pinfo) {
// 4. commit compaction
EditVersion version;
RETURN_IF_ERROR(_commit_compaction(pinfo, *output_rowset, &version));
// already committed, so we can ignore timeout error here
std::unique_lock<std::mutex> ul(_lock);
_wait_for_version(version, 120000, ul);
{
// already committed, so we can ignore timeout error here
std::unique_lock<std::mutex> ul(_lock);
_wait_for_version(version, 120000, ul);
}
// Release metadata memory after rowsets have been compacted.
Rowset::close_rowsets(input_rowsets);
return Status::OK();
}

Expand Down
Loading