Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add more profile and metrics to measure runtime bloom filter size (backport #46360) #46408

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 29, 2024

Why I'm doing:

What I'm doing:

Major changes:

  1. add new metrics to query profile to observe the memory occupied by partial runtime bloom filter.
  2. add new be system metrics to observe the number of rf events in the queue and the bloom filter memory consumption in the queue.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #46360 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

Major changes:

  1. add new metrics to query profile to observe the memory occupied by partial runtime bloom filter.
  2. add new be system metrics to observe the number of rf events in the queue and the bloom filter memory consumption in the queue.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…ilter size (#46360)

Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit 16ec9c1)

# Conflicts:
#	be/src/exec/pipeline/hashjoin/hash_join_build_operator.cpp
#	be/src/runtime/runtime_filter_worker.cpp
#	be/src/runtime/runtime_filter_worker.h
Copy link
Contributor Author

mergify bot commented May 29, 2024

Cherry-pick of 16ec9c1 has failed:

On branch mergify/bp/branch-3.1/pr-46360
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit 16ec9c16fe.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/exec/hash_joiner.cpp
	modified:   be/src/exec/hash_joiner.h
	modified:   be/src/exprs/runtime_filter.h
	modified:   be/src/util/system_metrics.cpp
	modified:   be/src/util/system_metrics.h

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/exec/pipeline/hashjoin/hash_join_build_operator.cpp
	both modified:   be/src/runtime/runtime_filter_worker.cpp
	both modified:   be/src/runtime/runtime_filter_worker.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label May 29, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) May 29, 2024 08:56
@mergify mergify bot closed this May 29, 2024
auto-merge was automatically disabled May 29, 2024 08:56

Pull request was closed

Copy link
Contributor Author

mergify bot commented May 29, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.1/pr-46360 branch May 29, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant