Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix array index out of bounds when collect equivalent slot pairs from set operators (backport #47321) #47435

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 25, 2024

Why I'm doing:

When enable query cache, FE report error "out of bounds" on some queries.

java.lang.IndexOutOfBoundsException: Index 6 out of bounds for length 6

 at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64) ~[?:?]

 at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70) ~[?:?]

 at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248) ~[?:?]

 at java.util.Objects.checkIndex(Objects.java:372) ~[?:?]

 at java.util.ArrayList.get(ArrayList.java:458) ~[?:?]

 at com.starrocks.planner.SetOperationNode.collectEquivRelation(SetOperationNode.java:377) ~[starrocks-fe.jar:?]

 at com.starrocks.planner.FragmentNormalizer.collectEquivRelation(FragmentNormalizer.java:901) ~[starrocks-fe.jar:?]

 at com.starrocks.planner.FragmentNormalizer.collectEquivRelation(FragmentNormalizer.java:899) ~[starrocks-fe.jar:?]

What I'm doing:

when slotId of the union child is re-used, descTbl only records unique slotIds, so the number of slotIds collected from descTbl is less than the number of union slotIds. so fix it, directly use mapping from union slotIds children's slotIds.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #47321 done by [Mergify](https://mergify.com). ## Why I'm doing: When enable query cache, FE report error "out of bounds" on some queries. ``` java.lang.IndexOutOfBoundsException: Index 6 out of bounds for length 6

at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64) ~[?:?]

at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70) ~[?:?]

at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248) ~[?:?]

at java.util.Objects.checkIndex(Objects.java:372) ~[?:?]

at java.util.ArrayList.get(ArrayList.java:458) ~[?:?]

at com.starrocks.planner.SetOperationNode.collectEquivRelation(SetOperationNode.java:377) ~[starrocks-fe.jar:?]

at com.starrocks.planner.FragmentNormalizer.collectEquivRelation(FragmentNormalizer.java:901) ~[starrocks-fe.jar:?]

at com.starrocks.planner.FragmentNormalizer.collectEquivRelation(FragmentNormalizer.java:899) ~[starrocks-fe.jar:?]

## What I'm doing:
when slotId of the union child is re-used, descTbl only records unique slotIds, so the number of slotIds collected from descTbl is less than the number of union slotIds. so fix it, directly use mapping from union slotIds children's slotIds.

Fixes #issue

## What type of PR is this:

- [x] BugFix
- [ ] Feature
- [ ] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool

Does this PR entail a change in behavior?

- [ ] Yes, this PR will result in a change in behavior.
- [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

## Checklist:

- [x] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
  - [ ] I have added documentation for my new feature or new function
- [x] This is a backport pr

…airs from set operators (#47321)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit abc33da)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/planner/SetOperationNode.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
#	fe/fe-core/src/test/java/com/starrocks/utframe/UtFrameUtils.java
Copy link
Contributor Author

mergify bot commented Jun 25, 2024

Cherry-pick of abc33da has failed:

On branch mergify/bp/branch-2.5/pr-47321
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit abc33daff3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   fe/fe-core/src/test/resources/sql/query_dump/query_cache_set_operator.json

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/planner/SetOperationNode.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/utframe/UtFrameUtils.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Jun 25, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-47321 branch June 25, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant