[BugFix] Fix match of source ip for resource group (backport #47732) #47808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #47437.
Match
SubnetUtils::isInRange
doesn't consider the broadcast and network address as a usable endpoint by default. As a result,127.0.0.1
cannot matched127.0.0.1/32
.Weight
The weight of
sourceIP
of a resource group classifier is1 + cidrPrefixLength/64
. However, we calculatecidrPrefixLength
byLong.numberOfLeadingZeros(subnetUtils.getInfo().getAddressCountLong()) - 32
, which should beLong.numberOfLeadingZeros(subnetUtils.getInfo().getAddressCountLong()) - 31
.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #47732 done by [Mergify](https://mergify.com). ## Why I'm doing:
What I'm doing:
Fixes #47437.
Match
SubnetUtils::isInRange
doesn't consider the broadcast and network address as a usable endpoint by default. As a result,127.0.0.1
cannot matched127.0.0.1/32
.Weight
The weight of
sourceIP
of a resource group classifier is1 + cidrPrefixLength/64
. However, we calculatecidrPrefixLength
byLong.numberOfLeadingZeros(subnetUtils.getInfo().getAddressCountLong()) - 32
, which should beLong.numberOfLeadingZeros(subnetUtils.getInfo().getAddressCountLong()) - 31
.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: