[BugFix] Fix incorrect connection state update when register/unregister conn (backport #48056) #48167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Connection state update is incorrect.
What I'm doing:
Currently we need to update a few maps and counters when register/unregister
connection from FE, we don't have some sync mechanism to protect this update,
which may cause incorrect connection state and prompt "connection reach limit"
unexpectly to user login. Add lock protection when register/unregister connection,
the performance should be ok, we have moved some heavy operations like cleaning
tmp table outside of lock, and the rest are just some simple map get/put operations.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #48056 done by [Mergify](https://mergify.com). ## Why I'm doing: Connection state update is incorrect.
What I'm doing:
Currently we need to update a few maps and counters when register/unregister
connection from FE, we don't have some sync mechanism to protect this update,
which may cause incorrect connection state and prompt "connection reach limit"
unexpectly to user login. Add lock protection when register/unregister connection,
the performance should be ok, we have moved some heavy operations like cleaning
tmp table outside of lock, and the rest are just some simple map get/put operations.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: