Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support Predicate Push Down in MaxCompute Catalog #48573

Closed
wants to merge 10 commits into from
Closed

[Enhancement] Support Predicate Push Down in MaxCompute Catalog #48573

wants to merge 10 commits into from

Conversation

dingxin-tech
Copy link
Contributor

@dingxin-tech dingxin-tech commented Jul 18, 2024 •
edited by github-actions bot
Loading

Why I'm doing:

What I'm doing:

Fixes #48570

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@dingxin-tech dingxin-tech requested a review from a team as a code owner July 18, 2024 09:34
@dingxin-tech dingxin-tech changed the title [Enhancement] Support Predicate Push Down in MaxCompute Catalog #48570 [Enhancement] Support Predicate Push Down in MaxCompute Catalog Jul 18, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation 3.3 labels Jul 18, 2024
stephen-shelby
stephen-shelby reviewed Jul 22, 2024
View reviewed changes
docs/en/data_source/catalog/maxcompute_catalog.md
| odps.split.policy | No | The shard policy used when for data scanning. <br />Valid values: `size` (shard by data size) and `row_offset` (shard by number of rows). Default value: `size`.<br /> |
| odps.split.row.count | No | The maximum number of rows per shard when `odps.split.policy` is set to `row_offset`. <br />Default value: `4 * 1024 * 1024 = 4194304`.<br /> |
| Parameter | Required | Description |
|-----------------------|----------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@dingxin-tech dingxin-tech force-pushed the feature/predicate_pushdown_new branch from 19a1e03 to 624f47f Compare July 22, 2024 12:32
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 78 / 95 (82.11%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/odps/OdpsMetadata.java 24 40 60.00% [284, 285, 286, 287, 288, 289, 363, 373, 374, 376, 377, 380, 385, 400, 424, 440]
🔵 com/starrocks/connector/odps/EntityConvertUtils.java 50 51 98.04% [161]
🔵 com/starrocks/connector/odps/OdpsProperties.java 1 1 100.00% []
🔵 com/starrocks/connector/odps/OdpsPartition.java 3 3 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-shelby stephen-shelby stephen-shelby approved these changes

Assignees

@dingxin-tech dingxin-tech

Labels
3.3 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support Predicate Push Down in MaxCompute Catalog
2 participants
@dingxin-tech @stephen-shelby