[BugFix] Fix the problem that Stream/Routine Load memory statistics are not accurate. #48587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re not accurate. Signed-off-by: stdpain <[email protected]>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
wyb
approved these changes
Jul 19, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 16 / 26 (61.54%) file detail
|
dirtysalt
approved these changes
Jul 19, 2024
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
…re not accurate. (#48587) Signed-off-by: stdpain <[email protected]> (cherry picked from commit 321ce64)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 24, 2024
…re not accurate. (backport #48587) (#48629) Co-authored-by: stdpain <[email protected]>
dujijun007
pushed a commit
to dujijun007/starrocks
that referenced
this pull request
Jul 29, 2024
…re not accurate. (StarRocks#48587) Signed-off-by: stdpain <[email protected]>
srlch
added a commit
to srlch/starrocks
that referenced
this pull request
Aug 2, 2024
…stion Why I'm doing: In this pr StarRocks#48587, process memory tracker was introduced to track the memory usage in ByteBuffer allocation. But currently, ByteBuffer is only used for data ingestion and we should track using load memory track and limited by the tracker. What I'm doing: 1. Use load memory tracker instead. 2. limit the memory allocation using this tracker. Signed-off-by: srlch <[email protected]>
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
in routine load ByteBuffer is allocate from kafka thread (process memory tracker)
kafka-thread pool->KafkaDataConsumerGroup::start_all -> KafkaConsumerPipe::append_with_row_delimiter
but it was release in instance memory tracker
FileScanNode->thread pool -> CSVReader -> read()
so when PlanfragmentExecutor. the instance tracker will be a negative number
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: